label/arrow position when data towards bottom

[alfred-c]

RE: Issue #9 Arrows and description not displaying in correct position
If data is towards the bottom of the screen, label should be on top, but existing code would cause label and arrow to overlap.
To fix, I removed the following offending lines and cleaned up unused variables:

if (top_offset < label_shift_with_label_height && bottom_offset < label_shift_with_label_height) {
     label_y = data.center_y + label_margin;
}

Not sure why this was added. Please review this section as it looks like the result of a bad merge.

[zapper59]

Hi, I'm working on merging bug fixes into https://github.com/darron1217/enjoyhint.js
I just tried this bug fix on that fork and it does not seem to fix the issue.

[alfred-c]

The fork I referenced is at https://github.com/xbsoftware/enjoyhint, master branch, enjoyhint.js at the root (not sure why there's a different version in src folder) On Tue, Jun 19, 2018 at 9:39 AM, Brian Richer <[email protected]<mailto:[email protected]>> wrote: Hi, I'm working on merging bug fixes into https://github.com/darron1217/enjoyhint.js I just tried this bug fix on that fork and it does not seem to fix the issue. [image]<https://user-images.githubusercontent.com/9943931/41611433-6c593b6e-73b5-11e8-87a7-bb63a68f4074.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#85 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABInQXaVwkc07exSH025rJHDsqVZtQelks5t-SlUgaJpZM4SprNE>.

[zapper59]

Didn't make that clear, I get the same behavior applying the bug fix to either branch. The js file in the root is auto generated by grunt. Take a look at the json file.

[arkauss83]

Hi, I found a couple of bugs related with this issue.

In one hand, I found out that the following code in renderLabel function was buggy:
var label_w = label.width();
var label_h = label.height();
var label_left = label.offset().left;
var label_right = label.offset().left + label_w;
var label_top = label.offset().top - $(document).scrollTop();
var label_bottom = label.offset().top + label_h;
So, basing on how is calculated label_top, I replaced label_bottom calculation with this:
var label_bottom = label.offset().top - $(document).scrollTop() + label_h;

In the other hand, these variables were calculated wrongly as well:
var is_top = (label_data.bottom < shape_data.top);
var is_bottom = (label_data.top > shape_data.bottom);
var is_mid = (label_data.bottom >= shape_data.y && label_data.top <= shape_data.y);
var is_mid_top = (label_data.bottom <= shape_data.y && !is_top);
var is_mid_bottom = (label_data.top >= shape_data.y && !is_bottom);
So I replaced the code with this:
var is_top = ((label_data.top + label_height) < shape_data.top);
var is_bottom = (label_data.top > shape_data.bottom);
var is_mid = ((label_data.top + label_height) >= shape_data.y && label_data.top <= shape_data.y);
var is_mid_top = (label_data.top + label_height <= shape_data.y && !is_top);
var is_mid_bottom = (label_data.top >= shape_data.y && !is_bottom);

After this, any scenario in my app when both the label and arrow are rendered above the highlighted canvas worked fine.
Hope it helps!

[rdorazio]

arkauss83,
I had a problem with the arrow. With your code I was able to solve the problem.
Thank you