Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ClearKey] Fix base64 encoding/decoding #1655

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

CastagnaIT
Copy link
Collaborator

Description

as https://www.w3.org/TR/encrypted-media/#using-base64url:

characters '-' and '_' MUST be used instead of '+' and '/', respectively

Motivation and context

fix #1637 (comment)

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue Backport: Needed v22 Piers DRM: ClearKey labels Aug 25, 2024
@CastagnaIT CastagnaIT merged commit 6ece294 into xbmc:Piers Aug 26, 2024
10 checks passed
@CastagnaIT CastagnaIT deleted the fix_cc_encdec branch August 26, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done DRM: ClearKey Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Add support for fetching keys from Licence Server
1 participant