Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLS] Implemented PlayReady support #1643

Merged
merged 1 commit into from
Aug 22, 2024
Merged

[HLS] Implemented PlayReady support #1643

merged 1 commit into from
Aug 22, 2024

Conversation

CastagnaIT
Copy link
Collaborator

Description

Implemented PlayReady support to HLS

fixed bug on PRProtectionParser where if playready header higher than v4.0 was not parsing correctly the KID

Motivation and context

I was testing playready

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT force-pushed the hls_playready branch 3 times, most recently from a621215 to a76e7ee Compare August 21, 2024 15:42
@CastagnaIT CastagnaIT added Type: Feature non-breaking change which adds functionality v22 Piers labels Aug 21, 2024
@CastagnaIT CastagnaIT marked this pull request as ready for review August 21, 2024 15:43
@CastagnaIT CastagnaIT added the Type: Fix non-breaking change which fixes an issue label Aug 21, 2024
zuzia-dev added a commit to zuzia-dev/Kodi-Piers-addons-for-Linux that referenced this pull request Aug 21, 2024
@zuzia-dev
Upload files
09914cc 
Added:
xbmc/inputstream.adaptive#1643
xbmc/inputstream.adaptive#1647
xbmc/inputstream.adaptive#1649
@CastagnaIT
[HLSTree] Implemented playready support
1a5fadc 
This change include also a fix on PRProtectionParser::ParseHeader
where playready header versions > 4.0 was not extracting correctly the kid
@CastagnaIT CastagnaIT mentioned this pull request Aug 22, 2024
Merged
11 tasks
@CastagnaIT CastagnaIT merged commit a1346a5 into xbmc:Piers Aug 22, 2024
10 checks passed
@CastagnaIT CastagnaIT deleted the hls_playready branch August 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: HLS DRM: PlayReady Type: Feature non-breaking change which adds functionality Type: Fix non-breaking change which fixes an issue v22 Piers Wiki: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CastagnaIT