Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Session] Restored licenseData variable on for loop #1633

Merged
merged 1 commit into from
Aug 11, 2024
Merged

[Session] Restored licenseData variable on for loop #1633

merged 1 commit into from
Aug 11, 2024

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Aug 11, 2024 •
edited
Loading

Description

fix regression caused by #1598
that has moved licenseData variable outside the for loop

Motivation and context

partially fix #1632

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT
[Session] Restored licenseData variable on for loop
5476b81 
This variable is modified within the for loop
so place it outside will cause that sideeffects
because the variable is assigned by some conditions
@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v22 Piers labels Aug 11, 2024
@CastagnaIT CastagnaIT mentioned this pull request Aug 11, 2024
Merged
11 tasks
@CastagnaIT CastagnaIT merged commit f0a2887 into xbmc:Piers Aug 11, 2024
10 checks passed
@CastagnaIT CastagnaIT deleted the fix_licensedata branch August 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennguy glennguy glennguy approved these changes

Assignees
No one assigned
Labels
Backport: Done Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] problem with decrypting segments from ver. 21.5.1
2 participants
@CastagnaIT @glennguy