Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply select with update lock only for MSSQL for updatePropertyWithID method #4048

Draft
wants to merge 1 commit into
base: 4.10.x
Choose a base branch
from
Draft

Apply select with update lock only for MSSQL for updatePropertyWithID method #4048

wants to merge 1 commit into from

Conversation

UdeshAthukorala
Copy link

@UdeshAthukorala UdeshAthukorala commented Aug 12, 2024 •
edited
Loading

Purpose

The related PR added a change where an update lock is applied to the relevant user attribute rows before being updated. It was noted that this deadlock scenario occurs only in SQL Server, and this syntax of using lock hints WITH (UPDLOCK) is only supported in MSSQL. The deadlock scenario is not reproduced in H2. Therefore this PR excludes other types of DBs from being affected by this fix.

Related PRs

Related Issues

@UdeshAthukorala UdeshAthukorala marked this pull request as draft August 14, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@UdeshAthukorala