Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default version_comparable value to fix error thrown in APIs migrated from the version which doesn't support API Revisions #12036

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

RusJaI
Copy link
Contributor

@RusJaI RusJaI commented Jun 1, 2023

…grated from the version which doesn't support API Revisions
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +2.89 🎉

Comparison is base (3faade0) 45.22% compared to head (6a34493) 48.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12036      +/-   ##
==========================================
+ Coverage   45.22%   48.12%   +2.89%     
==========================================
  Files        1781     1781              
  Lines      127921   127963      +42     
  Branches    18304    18314      +10     
==========================================
+ Hits        57851    61578    +3727     
+ Misses      63255    59230    -4025     
- Partials     6815     7155     +340     
Flag Coverage Δ
integration_tests 42.77% <25.00%> (+3.35%) ⬆️
unit_tests 20.92% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/apimgt/persistence/RegistryPersistenceImpl.java 59.59% <25.00%> (+0.22%) ⬆️

... and 273 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RusJaI RusJaI merged commit d3386ee into wso2:master Jun 19, 2023
5 of 6 checks passed
@RusJaI RusJaI deleted the api-revision-fix branch June 19, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Version Comparable" value get disappeared on migrated APIs when restoring revisions.
2 participants