Support storing multiple mobile numbers and email addresses per user #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple-mobile-number-support # Conflicts: # components/org.wso2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/IdentityRecoveryConstants.java # components/org.wso2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/signup/UserSelfRegistrationManager.java
lashinijay
changed the title
...src/main/java/org/wso2/carbon/identity/recovery/handler/MobileNumberVerificationHandler.java
Outdated
Show resolved
Hide resolved
lashinijay
commented
Jun 4, 2024
...src/main/java/org/wso2/carbon/identity/recovery/handler/MobileNumberVerificationHandler.java
Show resolved
Hide resolved
lashinijay
commented
Jun 4, 2024
...src/main/java/org/wso2/carbon/identity/recovery/handler/MobileNumberVerificationHandler.java
Show resolved
Hide resolved
lashinijay
commented
Jun 4, 2024
...src/main/java/org/wso2/carbon/identity/recovery/handler/MobileNumberVerificationHandler.java
Outdated
Show resolved
Hide resolved
| if (claims.containsKey(IdentityRecoveryConstants.MOBILE_NUMBER_CLAIM) && | ||
| !verifiedMobileNumbers.contains(claims.get(IdentityRecoveryConstants.MOBILE_NUMBER_CLAIM))) { | ||
| throw new IdentityEventClientException(IdentityRecoveryConstants.ErrorMessages. | ||
| ERROR_CODE_MOBILE_NUMBER_SHOULD_BE_INCLUDED_IN_VERIFIED_MOBILES_LIST.getCode(), |
There was a problem hiding this comment.
Shall we rename this to something like ERROR_CODE_PRIMARY_MOBILE_NUMBER_SHOULD_BE_INCLUDED_IN_VERIFIED_MOBILES_LIST. By just looking at the variable name, got confused why we need to have this check here.
lashinijay
commented
Jun 4, 2024
...src/main/java/org/wso2/carbon/identity/recovery/handler/MobileNumberVerificationHandler.java
Outdated
Show resolved
Hide resolved
lashinijay
commented
Jun 4, 2024
...so2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Outdated
Show resolved
Hide resolved
lashinijay
commented
Jun 4, 2024
...very/src/main/java/org/wso2/carbon/identity/recovery/signup/UserSelfRegistrationManager.java
Outdated
Show resolved
Hide resolved
|
Update the license header |
lashinijay
commented
Jun 6, 2024
...src/test/java/org/wso2/carbon/identity/recovery/connector/UserClaimUpdateConfigImplTest.java
Outdated
Show resolved
Hide resolved
…/wso2/carbon/identity/recovery/connector/UserClaimUpdateConfigImplTest.java
lashinijay
force-pushed
the
mulitple-mobile-number-support
branch
from
618d0ee
to
bdee942
Compare
lashinijay
force-pushed
the
mulitple-mobile-number-support
branch
from
5f96aaa
to
d8f0d29
Compare
# Conflicts: # components/org.wso2.carbon.identity.recovery/src/main/java/org/wso2/carbon/identity/recovery/util/Utils.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This feature will be enabled by default for the latest product, however with the following config in
deployment.toml, the multiple support for email addresses and mobile numbers can be disabled.verifiedEmailAddresses and verifiedMobileNumbers claims can only be updated when
Enable user email verification on updateand the above config are both enabled.Multiple email addresses support
Users will be able to store multiple email addresses in newly introduced custom claim http://wso2.org/claims/emailAddresses and multiple verified email addresses in http://wso2.org/claims/verifiedEmailAddresses claim.
case 01
when
support multiple email and mobile numbers per userandEnable user email verification on updateis both enabled, the primary email address of the user (http://wso2.org/claims/emailaddress) can only be updated to one of the existing email addresses in verifiedEmailAddresses claim.case 02
when support multiple email and mobile numbers per user
is disabled andEnable user email verification on update` is enabled, users can directly update the primary email address (http://wso2.org/claims/emailaddress) which will initiate the email verification process for the update email address.Multiple mobile numbers support
Users will be able to store multiple mobile numbers in newly introduced custom claim http://wso2.org/claims/mobileNumbers and multiple verified mobile numbers in http://wso2.org/claims/verifiedMobileNumbers claim.
case 01
when
support multiple email and mobile numbers per userandEnable user mobile verification on updateis both enabled, the primary mobile number of the user (http://wso2.org/claims/mobile) can only be updated to one of the existing mobile numbers in verifiedMobileNumbers claim.case 02
when support multiple email and mobile numbers per user
is disabled andEnable user mobile verification on update` is enabled, users can directly update the primary mobile number (http://wso2.org/claims/mobile) which will initiate the mobile verification process for the update mobile number.Related Git Issue