Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nullability Annotations to Java Classes] Add wordpress.lint Dependency #2879

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Oct 24, 2023

Parent #2795
Closes #2818

This PR adds wordPress-lint checks to the project (2.0.0).


To test:

  1. Verifying that all the CI checks are successful (focus on the Lint related check and their reports: fluxc + plugins/woocommerce + example).
  2. Verify that the new MissingNullAnnotationOn* correctness related rules are reporting as expected. For a reference, see screenshots below:

fluxc module:

image

plugins/woocommerce module:

image

example module:

image


Merge instructions:

  • Wait for the accompanying Catalog#28 PR to be merged.
  • Release a new catalog version (1.15.0).
  • Update catalogVersion to point to the new 1.15.0 release.
  • Remove the [PR] Not Ready for Merge label.
  • Merge this PR.

FYI: This change was done for testing purposes and until the below
'Android Dependency Catalog' #28 PR gets merged to 'trunk'. When that's
done, the 'catalogVersion' will be updated to '1.15.0' instead.

PR: Automattic/android-dependency-catalog#28
Catalog: https://github.com/Automattic/android-dependency-catalog/
releases/tag/1.15.0
WordPress Lint: https://github.com/wordpress-mobile/
WordPress-Lint-Android/releases/tag/2.0.0

------------------------------------------------------------------------

FYI: 1415fb8
@ParaskP7
Copy link
Contributor Author

FYI: This is now ready for review + merge @wzieba (see merge instructions) ! ✅

Copy link
Contributor

@wzieba wzieba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@wzieba wzieba merged commit 09842f3 into trunk Oct 25, 2023
13 checks passed
@wzieba wzieba deleted the deps/add-wordpress-lint-dependency branch October 25, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullability Annotations to Java Classes - Add and Configure org.wordpress:lint version 2.0.0
2 participants