-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Automate Release Publishing #21239
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
# RELEASE_VERSION is passed as an environment variable passed to Buildkite by ReleasesV2. | ||
if [[ -z "${RELEASE_VERSION}" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adopted the same approach in Simplenote Android. But I plan to follow it up with a dedicated PR to remove the env read here and make the pipeline pass it when they call the script.
I'm not arguing for it to happen here at this time, but keen to hear what you think of the approach: https://github.com/Automattic/simplenote-android/pull/1695/files#r1766347252
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also make the implementation consistent with the recent changes accessing RELEASE_VERSION in the pipeline command that we made in some iOS projects.
I think this is a good idea. It's an area where we lack some standardization.
Besides, having these scripts relying less on environment variables and having those explicit in the pipelines make things clearer and easier to follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
This PR builds on top of #21229 and automates the release publishing, which means to:
This PR will be followed by updates to the Releases V2 tool.
This is the Android counterpart of wordpress-mobile/WordPress-iOS#23592