-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 소요시간 계산 외부 api 의존성 낮추기 #555
Open
hyeon0208
wants to merge
10
commits into
develop
Choose a base branch
from
feature/521
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+490
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results146 tests +5 139 ✅ +5 4s ⏱️ -1s Results for commit e4a93a2. ± Comparison against base commit 587cfb9. This pull request removes 6 and adds 11 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
📝 Test Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #521
📝 작업 내용
Google Distance Matrix API를 사용하는
RouteClient
구현체를 추가해OdsayRouteClient
에 장애가 발생하면GoogleRouteClient
로 소요시간을 계산할 수 있도록 의존성을 낮췄습니다.GoogleRouteClient
구현은아래 API 가이드 문서를 참고했습니다.
Google Distance Matrix API 가이드
@RestClientTest
를 상뇽하던OdsayRouteClientTest
에서 사용하고 있던 에서테스트할 구현체의 Bean을 지정해주어도 모든 구현체들을 구성으로 등록하려해 에러가 발생했어요
그래서 해당 테스트를 실행가능하도록 설정 부분을 수정했습니다
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)