-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 로그아웃 기능 구현 #493
Merged
Merged
feat: 로그아웃 기능 구현 #493
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a4fcad2
chore: swagger 문서 작성
3ba15ae
feat: 생성자 로직 변경
60f9e77
feat: 멤버 refreshToken 삭제 로직 구현
fd84f24
feat: 로그아웃 기능 구현
be6ecc8
feat: 리프레시 토큰 초기화 로직 일관성 준수
e4d3c42
feat: 리프레시 토큰 validate 추가
00e4f45
chore: 메서드 순서 변경
ddd4820
test: 불필요한 테스트 삭제
6e78ed2
feat: member 리프레시 토큰 update 기능 구현
dac90a6
feat: 로그아웃 기능 구현
66e3e64
chore: description 수정
a65ac99
chore: 로그아웃 시 401 description 설명 추가
6569d1b
refactor: 액세스 토큰만 받도록 로직 수정
d1746b1
style: test 네이밍 변경
aa038fd
test: 테스트 에러 해결
6e169dd
refactor: 불필요한 메서드 삭제
a5e40a0
refactor: 이미 로그아웃 상태더라도 200을 반환하도록 수정
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -25,13 +25,13 @@ class AuthServiceTest extends BaseServiceTest { | |||||
@Autowired | ||||||
private MemberRepository memberRepository; | ||||||
|
||||||
@DisplayName("로그 아웃 테스트") | ||||||
@DisplayName("로그아웃 테스트") | ||||||
@Nested | ||||||
class LogOutTest { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [필수]
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 반영 완료! |
||||||
|
||||||
@DisplayName("성공 : 유효한 액세스 토큰 + 유효한 리프레시 토큰") | ||||||
@DisplayName("성공 : 유효한 액세스 토큰") | ||||||
@Test | ||||||
void logOutSuccess() { | ||||||
void logoutSuccess() { | ||||||
RefreshToken validRefreshToken = TokenFixture.getValidRefreshToken(); | ||||||
Member member = createMemberByRefreshToken(validRefreshToken); | ||||||
AccessToken validAccessToken = TokenFixture.getValidAccessToken(member.getId()); | ||||||
|
@@ -42,39 +42,27 @@ void logOutSuccess() { | |||||
.doesNotThrowAnyException(); | ||||||
} | ||||||
|
||||||
@DisplayName("실패 : 만료된 액세스 토큰으로 로그아웃 시도 시 400을 반환한다") | ||||||
@DisplayName("실패 : 만료된 액세스 토큰으로 로그아웃 시도 시 401을 반환한다") | ||||||
@Test | ||||||
void logOutFail_When_ExpiredAccessToken() { | ||||||
void logoutFailWhenExpiredAccessToken() { | ||||||
RefreshToken validRefreshToken = TokenFixture.getValidRefreshToken(); | ||||||
Member member = createMemberByRefreshToken(validRefreshToken); | ||||||
AccessToken expiredAccessToken = TokenFixture.getExpiredAccessToken(member.getId()); | ||||||
String authorizationHeader = resolveAuthorizationHeader(expiredAccessToken, validRefreshToken); | ||||||
|
||||||
assertThatThrownBy(() -> authService.logout(authorizationHeader)) | ||||||
.isInstanceOf(OdyBadRequestException.class); | ||||||
} | ||||||
|
||||||
@DisplayName("실패 : 만료된 리프레시 토큰으로 로그아웃 시도 시 400을 반환한다") | ||||||
@Test | ||||||
void logOutFail_When_ExpiredRefreshToken() { | ||||||
RefreshToken expiredRefreshToken = TokenFixture.getExpiredRefreshToken(); | ||||||
Member member = createMemberByRefreshToken(expiredRefreshToken); | ||||||
AccessToken validAccessToken = TokenFixture.getValidAccessToken(member.getId()); | ||||||
String authorizationHeader = resolveAuthorizationHeader(validAccessToken, expiredRefreshToken); | ||||||
|
||||||
assertThatThrownBy(() -> authService.logout(authorizationHeader)) | ||||||
.isInstanceOf(OdyBadRequestException.class); | ||||||
.isInstanceOf(OdyUnauthorizedException.class); | ||||||
} | ||||||
|
||||||
@DisplayName("실패 : 액세스 토큰 파싱 멤버와 리프레시 토큰 정보가 일치하지 않으면 401을 반환한다") | ||||||
@DisplayName("실패 : 이미 로그아웃한 유저 엑세스 토큰으로 로그아웃 시도 시 400을 반환한다") | ||||||
@Test | ||||||
void logOutFail_When_NotSameMemberToken() { | ||||||
RefreshToken validRefreshToken = TokenFixture.getRefreshToken(TokenFixture.authPropertiesForValidToken); | ||||||
void logoutFailWhenTryAlreadyLogoutMember() { | ||||||
RefreshToken validRefreshToken = TokenFixture.getValidRefreshToken(); | ||||||
Member member = createMemberByRefreshToken(validRefreshToken); | ||||||
AccessToken validAccessToken = TokenFixture.getValidAccessToken(member.getId()); | ||||||
String authorizationHeader = resolveAuthorizationHeader(validAccessToken, validRefreshToken); | ||||||
|
||||||
RefreshToken otherRefreshToken = TokenFixture.getRefreshToken(TokenFixture.authPropertiesForValidToken2); | ||||||
String authorizationHeader = resolveAuthorizationHeader(validAccessToken, otherRefreshToken); | ||||||
member.updateRefreshToken(null); | ||||||
|
||||||
assertThatThrownBy(() -> authService.logout(authorizationHeader)) | ||||||
.isInstanceOf(OdyBadRequestException.class); | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[질문] 로그아웃 상태에서 로그아웃을 다시 시도했을 때 400과 200 중 무엇을 줄지 차람과 함께 고려했나요? 회원 삭제 API에서는 이런 상황에서 200을 주기로 결정해서 질문드립니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
반영했습니다! 좋은 포인트의 리뷰 감사합니다 🙇
a5e40a0