refactor: 지난 약속에 참여하지 못하도록 예외처리

backend/src/main/java/com/ody/meeting/service/MeetingService.java

@@ -1,5 +1,6 @@
 package com.ody.meeting.service;
 
+import com.ody.common.exception.OdyBadRequestException;
 import com.ody.common.exception.OdyNotFoundException;
 import com.ody.mate.domain.Mate;
 import com.ody.mate.dto.request.MateSaveRequestV2;
@@ -15,6 +16,8 @@
 import com.ody.meeting.repository.MeetingRepository;
 import com.ody.member.domain.Member;
 import com.ody.util.InviteCodeGenerator;
+import com.ody.util.TimeUtil;
+import java.time.LocalDateTime;
 import java.util.Comparator;
 import java.util.List;
 import java.util.stream.Collectors;
@@ -85,6 +88,9 @@ public MeetingWithMatesResponse findMeetingWithMates(Member member, Long meeting
     @Transactional
     public MateSaveResponseV2 saveMateAndSendNotifications(MateSaveRequestV2 mateSaveRequest, Member member) {
         Meeting meeting = findByInviteCode(mateSaveRequest.inviteCode());
+        if (meeting.isEnd()) {
+            throw new OdyBadRequestException("과거 약속에 참여할 수 없습니다.");
+        }
         return mateService.saveAndSendNotifications(mateSaveRequest, member, meeting);
     }
 }

backend/src/test/java/com/ody/meeting/service/MeetingServiceTest.java

@@ -1,16 +1,20 @@
 package com.ody.meeting.service;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatCode;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.junit.jupiter.api.Assertions.assertAll;
 
 import com.ody.common.BaseServiceTest;
 import com.ody.common.Fixture;
+import com.ody.common.exception.OdyBadRequestException;
 import com.ody.common.exception.OdyNotFoundException;
 import com.ody.mate.domain.Mate;
 import com.ody.mate.domain.Nickname;
+import com.ody.mate.dto.request.MateSaveRequestV2;
 import com.ody.mate.dto.response.MateResponse;
 import com.ody.mate.repository.MateRepository;
+import com.ody.meeting.domain.Location;
 import com.ody.meeting.domain.Meeting;
 import com.ody.meeting.dto.request.MeetingSaveRequestV1;
 import com.ody.meeting.dto.response.MeetingFindByMemberResponse;
@@ -187,4 +191,48 @@ void findMeetingWithMatesException() {
         assertThatThrownBy(() -> meetingService.findMeetingWithMates(member, 1L))
                 .isInstanceOf(OdyNotFoundException.class);
     }
+
+    @DisplayName("지나지 않은 약속에 참여가 가능하다")
+    @Test
+    void saveMateSuccess() {
+        Meeting notOverdueMeeting = makeSavedMeetingByRemainingMinutes(1L);
+        Member member = memberRepository.save(Fixture.MEMBER2);
+        MateSaveRequestV2 mateSaveRequest = makeMateRequestByMeeting(notOverdueMeeting);
+
+        assertThatCode(() -> meetingService.saveMateAndSendNotifications(mateSaveRequest, member))
+                .doesNotThrowAnyException();
+    }
+
+    @DisplayName("지난 약속에 참여가 불가하다")
+    @Test
+    void saveMateFail_When_tryAttendOverdueMeeting() {
+        Meeting overdueMeeting = makeSavedMeetingByRemainingMinutes(-1L);
+        Member member = memberRepository.save(Fixture.MEMBER1);
+        MateSaveRequestV2 mateSaveRequest = makeMateRequestByMeeting(overdueMeeting);
+
+        assertThatThrownBy(() -> meetingService.saveMateAndSendNotifications(mateSaveRequest, member))
+                .isInstanceOf(OdyBadRequestException.class);
+    }
+
+    private MateSaveRequestV2 makeMateRequestByMeeting(Meeting meeting) {
+        Location origin = Fixture.ORIGIN_LOCATION;
+        return new MateSaveRequestV2(
+                InviteCodeGenerator.encode(meeting.getId()),
+                origin.getAddress(),
+                origin.getLatitude(),
+                origin.getLongitude()
+        );
+    }
+
+    private Meeting makeSavedMeetingByRemainingMinutes(long remainingMinutes) {
+        LocalDateTime time = TimeUtil.nowWithTrim().plusMinutes(remainingMinutes);
+        Meeting meeting = new Meeting(
+                "오디",
+                time.toLocalDate(),
+                time.toLocalTime(),
+                Fixture.TARGET_LOCATION,
+                "초대코드"
+        );
+        return meetingRepository.save(meeting);
+    }
 }