refactor: 지난 약속에 참여하지 못하도록 예외처리 #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results121 tests 113 ✅ 4s ⏱️ Results for commit 62e596a. |
📝 Test Coverage Report
|
mzeong
approved these changes
Sep 6, 2024
Comment on lines
91
to
101
| if (isOverDueMeeting(meeting)) { | ||
| throw new OdyBadRequestException("과거 약속에 참여할 수 없습니다."); | ||
| } | ||
| return mateService.saveAndSendNotifications(mateSaveRequest, member, meeting); | ||
| } | ||
|
|
||
| private boolean isOverDueMeeting(Meeting meeting) { | ||
| LocalDateTime now = TimeUtil.nowWithTrim(); | ||
| LocalDateTime meetingTime = meeting.getMeetingTime(); | ||
| return now.isAfter(meetingTime); | ||
| } |
There was a problem hiding this comment.
[제안] 지난 약속인지 판별을 Meeting에서 해도 좋을 것 같아요
if (meeting.isOverdue()) {
...
}public boolean isOverdue() {
LocalDateTime now = TimeUtil.nowWithTrim();
return now.isAfter(getMeetingTime());
}+테스트는 overdue로 작성되었는데, 여기는 overDue로 작성되었어요
There was a problem hiding this comment.
[반영 완료]
- meeting에게 끝났는지를 묻는 isEnd() 메서드가 있어서 활용했습니다!
@Transactional
public MateSaveResponseV2 saveMateAndSendNotifications(MateSaveRequestV2 mateSaveRequest, Member member) {
Meeting meeting = findByInviteCode(mateSaveRequest.inviteCode());
if (meeting.isEnd()) {
throw new OdyBadRequestException("과거 약속에 참여할 수 없습니다.");
}
return mateService.saveAndSendNotifications(mateSaveRequest, member, meeting);
}
hyeon0208
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #473
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)