[BE] 체크리스트 좋아요 서비스 구조를 분리한다. #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JINU-CHANG
requested changes
Sep 19, 2024
Comment on lines
28
to
31
| private void validateChecklistLike(User user, Checklist checklist) { | ||
| validateChecklistOwnership(user, checklist); | ||
| validateChecklistAlreadyLiked(checklist); | ||
| } |
There was a problem hiding this comment.
메서드가 2개면 굳이 묶을 필요없다고 생각해요! createLike() 내에 두면 파악이 좀 더 쉬울 것 같아요~
| @Transactional | ||
| public void deleteLike(User user, Checklist checklist) { | ||
| validateChecklistOwnership(user, checklist); | ||
| ChecklistLike checklistLike = checklistLikeRepository.getByChecklistId(checklist.getId()); |
There was a problem hiding this comment.
repository 메서드 파라미터 타입 long -> Long으로 변경부탁드려요 !
|
|
||
| //then | ||
| assertAll( | ||
| () -> assertThat(response.checklists().size()).isEqualTo(2), |
There was a problem hiding this comment.
Suggested change
| () -> assertThat(response.checklists().size()).isEqualTo(2), | |
| () -> assertThat(response.checklists().size()).hasSize(2), |
2 상수로 빼면 좋을 것 같아요!
| @Autowired | ||
| private ChecklistLikeRepository checklistLikeRepository; | ||
|
|
||
| @DisplayName("체크리스트 좋아요 추가 성공") |
shin-jisong
requested changes
Sep 20, 2024
| @@ -3,6 +3,8 @@ | |||
| import com.bang_ggood.checklist.domain.Checklist; | |||
| import com.bang_ggood.checklist.dto.request.ChecklistRequest; | |||
| import com.bang_ggood.checklist.dto.response.SelectedChecklistResponse; | |||
| import com.bang_ggood.checklist.dto.response.UserChecklistPreviewResponse; | |||
There was a problem hiding this comment.
저희가 체크리스트 공유 기능이 있지 않고, 체크리스트에 유저 정보가 포함되지 않을 일이 없는데 user 명명을 쓴 이유가 궁금해요!
There was a problem hiding this comment.
예전에 사용하던거 그대로 사용했는데, User 빼도 좋을 것 같아서 이름 변경했습니다!
| import org.springframework.web.bind.annotation.PostMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController |
There was a problem hiding this comment.
작업량이 꽤나 많았겠네요 수고하셨습니다 👍
JINU-CHANG
approved these changes
Sep 20, 2024
shin-jisong
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
체크리스트 목록 좋아요 필터링 기능을 다음과 같은 순서로 구현하려고 시도했습니다.
하지만 ChecklistLike가 User를 가지고 있지 않아 Checklist, User와 join을 해야했습니다.
해당 방식도 동일한 join을 해야하기 때문에 기존 코드를 그대로 가져가는게 좋을 것 같아 유지했습니다.
다른 의견 있으시면 말씀해주세요!
🎸 기타