Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] 아티클에 대표 이미지를 추가한다. #606

Closed
wants to merge 5 commits into from

Conversation

tsulocalize
Copy link
Contributor

❗ Issue

✨ 구현한 기능

  • Response 내 이미지 주소 추가
  • DB 구조 변경

📢 논의하고 싶은 내용

🎸 기타

API endpoint 바꿨는데 어떤지 확인해주세용

Copy link
Contributor

@JINU-CHANG JINU-CHANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 작업이랑 머지하면서 잘못 머지된 것 같아서 확인 부탁드려요! 제가 작업했던 부분이 되돌아간것 같아요 ..!

Comment on lines +55 to +56
@PathVariable("id") long id) {
return ResponseEntity.ok(checklistService.readChecklistById(user, id));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long 타입 아닌가요??

}

@GetMapping("/checklists")
public ResponseEntity<UserChecklistsPreviewResponse> readChecklistsPreview(@AuthPrincipal User user) {
return ResponseEntity.ok(checklistService.readChecklistsPreview(user));
}

@GetMapping("/custom-checklist/all")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 작업에서 QuestionController로 분리되지 않았었나요??

@tsulocalize
Copy link
Contributor Author

pull 받아오는 과정에서 오류가 있었나봅니당... 수정후 다시 요청드릴게요

@tsulocalize tsulocalize deleted the feat/601-article-thumbnail branch September 19, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants