Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - npm ERR! Missing script: "test:e2e" #75

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

faisal-alvi
Copy link
Member

@faisal-alvi faisal-alvi commented Feb 27, 2024

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This is just a quick fix for https://github.com/woocommerce/woocommerce-square/actions/runs/8055460715/job/22002369524

Steps to test the changes in this Pull Request:

We have to push something to the smoke-test branch and confirm the e2e tests run.

Changelog entry

Fix - npm ERR! Missing script: "test:e2e"

@faisal-alvi
Copy link
Member Author

faisal-alvi commented Feb 27, 2024

The push was made and tests started running.

https://github.com/woocommerce/woocommerce-square/actions/runs/8066531193/job/22034781663

Most of the tests are failing though, there may be other issues that need to be addressed in a separate PR.

@faisal-alvi
Copy link
Member Author

Just note that this is already merged into smoke-testing branch.

@vikrampm1 vikrampm1 modified the milestones: Future Release, 4.6.0 Mar 1, 2024
@vikrampm1 vikrampm1 marked this pull request as ready for review March 1, 2024 14:20
@vikrampm1 vikrampm1 merged commit 75d8cd3 into trunk Mar 1, 2024
7 of 8 checks passed
@vikrampm1 vikrampm1 deleted the fix/npm-error branch March 1, 2024 14:21
@vikrampm1 vikrampm1 mentioned this pull request Mar 25, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants