Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.8.0 #204

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Release/4.8.0 #204

merged 12 commits into from
Sep 16, 2024

Conversation

dkotter
Copy link
Contributor

@dkotter dkotter commented Aug 23, 2024

Changes proposed in this Pull Request:

Version bump and prep for the 4.8.0 release

Closes #203

Steps to test the changes in this Pull Request:

Verify all file changes look accurate

@dkotter
Copy link
Contributor Author

dkotter commented Aug 23, 2024

We have one failing E2E test here that needs looked at. I retried the tests a few times but that particular test failed each time

@vikrampm1
Copy link
Contributor

@iamdharmesh there is one failed E2E test here. Could you please review and fix it so we can unblock the release? Thanks.

@iamdharmesh
Copy link
Member

The failing test is a newly added test in PR #72 (it is failing there as well). Checking on it.

@iamdharmesh
Copy link
Member

While checking and fixing the tests, I noticed that the toggle for enabling/disabling stock management is not working in the new product editor. I'm not sure if this is related to the WC 9.2 updates. @Sidsector9 @qasumitbagthariya could you please help to check at your end to confirm the issue?

Screenshot 2024-08-28 at 11 57 32 AM

Thank you.

@iamdharmesh iamdharmesh added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Aug 28, 2024
@qasumitbagthariya
Copy link
Contributor

@iamdharmesh

I've cross-checked with different WooCommerce versions, 9.1.4 and 9.2.3, and confirmed the issue with version 9.2.3.

WooCommerce versions 9.1.4 ✅

9.1.4.mov

WooCommerce versions 9.2.3 ⚠️

Screen.Recording.2024-08-28.at.1.58.22.PM.mov

@Sidsector9
Copy link
Member

@qasumitbagthariya I have pushed fixes, can you check?

@qasumitbagthariya
Copy link
Contributor

@Sidsector9 Thanks for the fix.

I've cross-checked with WooCommerce version 9.2.3, and enabling/disabling stock management is now working correctly with the new product editor.

I tested the following on this branch:
stock management - new product editor ✅
stock management - Old product editor ✅

WooCommerce version 9.2.3

Screen.Recording.2024-09-02.at.3.51.52.PM.mov

WooCommerce version 9.1.4

9.1.4.mov

@dkotter
Copy link
Contributor Author

dkotter commented Sep 3, 2024

@Sidsector9 @iamdharmesh Just following up on what is left to get this release unblocked? Seems E2E tests are still failing but looks like we fixed the other issue found but just wondering if there are other things that need addressed?

@iamdharmesh
Copy link
Member

@dkotter I found that issue while investigating the root cause of the failing E2E tests and @Sidsector9 fixed the reported issue, but the E2E test action is still failing. I think it would be best to review and fix the E2E tests. @Sidsector9, Please let me know if you want me to check the E2E test failures here.

@Sidsector9
Copy link
Member

@iamdharmesh @dkotter I'll look into it tomorrow 👍

@Sidsector9
Copy link
Member

@dkotter the CashApp tests are failing on Woo 9.3.0-beta.1 but passes for Woo 9.2.3. (Couldn't figure out the reason)

  • I have fixed an E2E test related to the new Product Block editor.
  • @iamdharmesh will be looking into the CashApp tests as it requires more investigation.

@iamdharmesh iamdharmesh removed status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. needs: e2e testing labels Sep 13, 2024
@iamdharmesh
Copy link
Member

@dkotter @vikrampm1 This is unblocked now.

@dkotter
Copy link
Contributor Author

dkotter commented Sep 13, 2024

@iamdharmesh I pushed a commit up to change the release date and tests are failing again 😢 Tried running them a couple times to see if it was just a flaky test but always failed

@iamdharmesh
Copy link
Member

@iamdharmesh I pushed a commit up to change the release date and tests are failing again 😢 Tried running them a couple times to see if it was just a flaky test but always failed

@dkotter, this is a bit strange. I'm unable to download the artifact from the failure to determine the root cause, but in my latest commit, a few tests failed twice and are now passing (I tried two times: 1, 2)—and that’s without making any code changes. So, that seems flaky tests, I suspect this might be due to a sandbox issue. I noticed this message about degraded performance on the Square Discord. I’ll keep an eye on the tests for PRs to better understand the issue, but for now, I feel we’re good to proceed with the next steps here.

@dkotter dkotter merged commit ccd4ebf into trunk Sep 16, 2024
6 checks passed
@dkotter dkotter deleted the release/4.8.0 branch September 16, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release version 4.8.0
5 participants