Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Product.php #191

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Update Product.php #191

merged 6 commits into from
Aug 23, 2024

Conversation

sunile2m
Copy link
Contributor

@sunile2m sunile2m commented Jul 29, 2024

Bug accessing database table with statically added "wp_" db prefix.

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

Closes # .

Steps to test the changes in this Pull Request:

Changelog entry

Update - Database table prefix to be variable and not hard-coded to wp_.

Bug accessing database table with statically added "wp_" db prefix.
@vikrampm1 vikrampm1 requested a review from dkotter July 30, 2024 11:57
@vikrampm1 vikrampm1 added this to the Future Release milestone Jul 30, 2024
includes/Handlers/Product.php Outdated Show resolved Hide resolved
Cool

Co-authored-by: Darin Kotter <[email protected]>
includes/Handlers/Product.php Outdated Show resolved Hide resolved
@qasumitbagthariya
Copy link
Contributor

QA Update ✅


I have verified this PR in the sunile2m:trunk branch and functioning as intended.

I tested the following on this branch:

  • Import product (simple, variable)
  • Sync
  • Simple product
  • Subscription product / renew product

Testing Environment

  • WordPress: 6.6.1
  • Theme: Storefront 4.6.0
  • Theme: Twenty Twenty-Four 1.2
  • WooCommerce - 9.1.4
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 13.3
  • Branch: sunile2m:trunk

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for code review (Woo)
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@qasumitbagthariya qasumitbagthariya requested review from a team and Mayisha and removed request for a team August 5, 2024 15:05
@jeffpaul jeffpaul removed the request for review from Mayisha August 5, 2024 16:44
@qasumitbagthariya
Copy link
Contributor

Regression / Smoke Test Report ✅

Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.5.5, npm version 8.19.4, node version 16.20.0)

Status- Working expected with Plugin Archive/Zip file same as fix specific branch.

Testing Environment

  • WordPress: 6.6.1
  • Theme: Storefront 4.6.0
  • Theme: Twenty Twenty-Four 1.2
  • WooCommerce - 9.1.4
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 13.3
  • Branch: smoke-testing

Next Step- Ready to Merge 🚀

@vikrampm1 vikrampm1 modified the milestones: Future Release, 4.8.0 Aug 23, 2024
@vikrampm1 vikrampm1 merged commit bfa9ff3 into woocommerce:trunk Aug 23, 2024
7 of 8 checks passed
@vikrampm1 vikrampm1 mentioned this pull request Aug 23, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants