Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the use of deprecated hook wcs_renewal_order_meta with wc_subscriptions_renewal_order_data #186

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Jul 25, 2024

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

PR makes a minor change to replace the deprecated hook wcs_renewal_order_meta with wc_subscriptions_renewal_order_data

Closes #179

Steps to test the changes in this Pull Request:

Detailed steps are given in the issue #179 description, Please verify that no deprecated notice is there in the error logs.

Changelog entry

Dev - Replace the use of deprecated hook wcs_renewal_order_meta with wc_subscriptions_renewal_order_data.

@iamdharmesh iamdharmesh self-assigned this Jul 25, 2024
@iamdharmesh iamdharmesh added this to the Future Release milestone Jul 25, 2024
@iamdharmesh iamdharmesh requested a review from dkotter July 25, 2024 11:49
@qasumitbagthariya
Copy link
Contributor

QA Update ✅


I have verified this PR in the fix/179 branch has been fixed and is functioning as intended.

I tested the following on this branch:

  • I can't reproduce with block checkout, but also able to reproduce the issue with shortcode base checkout
  • Renewal orders

Testing Environment

  • WordPress: 6.6.1
  • Theme: Storefront 4.6.0
  • Theme: Twenty Twenty-Four 1.2
  • WooCommerce - 9.1.4
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 13.3
  • Branch: fix/179

Steps to Test- As mentioned in the PR description.
Test Results - It is working as expected.
Functional Demo / Screencast -
Special Notes - Ready for code review (Woo)
Testing Document status:
Cases related to this Issue/PR are added to the Critical Flow Wiki pages:

  • Yes
  • Not Required/Applicable for this PR

@qasumitbagthariya qasumitbagthariya requested review from a team and Mayisha and removed request for a team August 5, 2024 10:00
@vikrampm1
Copy link
Contributor

@Mayisha this PR is ready for your review!

Copy link

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Confirming that wc_subscriptions_renewal_order_data is being called during a subscription renewal.

@qasumitbagthariya
Copy link
Contributor

Regression / Smoke Test Report ✅

Tested with Archive File created via "php woorelease.phar build repo_URL" (Composer version 2.5.5, npm version 8.19.4, node version 16.20.0)

Status- Working expected with Plugin Archive/Zip file same as fix specific branch.

Testing Environment

  • WordPress: 6.6.1
  • Theme: Twenty Twenty-Four 1.2
  • WooCommerce - 9.1.4
  • WooCommerce Subscription - 6.5.0
  • PHP: 8.0.30
  • Web Server: Nginx 1.20.2
  • Browser: Chrome
  • OS: macOS Ventura 13.3
  • Branch: smoke-testing

Next Step- Ready to Merge 🚀

@vikrampm1 vikrampm1 modified the milestones: Future Release, 4.8.0 Aug 23, 2024
@vikrampm1 vikrampm1 marked this pull request as ready for review August 23, 2024 15:12
@vikrampm1 vikrampm1 merged commit 5ab926a into trunk Aug 23, 2024
5 of 6 checks passed
@vikrampm1 vikrampm1 deleted the fix/179 branch August 23, 2024 15:12
@vikrampm1 vikrampm1 mentioned this pull request Aug 23, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The 'wcs_renewal_order_meta' filter is deprecated
5 participants