Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compat Checker – Fix admin notices not triggered when WooCommerce is not installed #83

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Compat Checker – Fix admin notices not triggered when WooCommerce is not installed #83

merged 2 commits into from
Oct 10, 2023

Conversation

ibndawood
Copy link
Contributor

@ibndawood ibndawood commented Oct 10, 2023 •
edited
Loading

Changes proposed in this Pull Request:

Closes #82.

This PR fixes the issue wherein admin notices are not triggered when WooCommerce is not installed.

Detailed test instructions:

  1. Setup the compat checker code in any of the plugins by following the Getting Started instructions here: https://github.com/woocommerce/grow/tree/trunk/packages/php/compat-checker#getting-started
  2. On a fresh WordPress installation without WooCommerce installed, activate the plugin.
  3. Without this PR: No admin notice is shown.
  4. With this PR: Admin notices are triggered.

Changelog entry

Fix - Admin notices not triggered when WooCommerce is not installed.

@ibndawood ibndawood self-assigned this Oct 10, 2023
layoutd
layoutd approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@layoutd layoutd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works in testing with a couple extensions, sorry I didn't catch this on the original PR!

@ibndawood
Copy link
Contributor Author

Thank you, @layoutd, for the review. I also thank you for catching this issue. I'll now merge this PR.

@ibndawood ibndawood merged commit 4486cc1 into trunk Oct 10, 2023
1 check passed
@ibndawood ibndawood deleted the fix/82-admin-notices-not-triggered branch October 10, 2023 12:14
@ibndawood ibndawood mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layoutd layoutd layoutd approved these changes

Assignees

@ibndawood ibndawood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compat Checker – Admin notices are not triggered when WooCommerce is not installed
2 participants
@ibndawood @layoutd