Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Plugin releases Action: Fix error counting RC releases #66

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jul 21, 2023

Changes proposed in this Pull Request:

Closes #65

RC was not being counted as the output for plugins other than WordPress. So when we added Including RC option they were adding more releases than expected.

Detailed test instructions:

  1. Check if the Pre Release is Compiling
  2. Check if the action outputs make sense.

Additional details:

Changelog entry

Fix - Error counting RC releases.

@puntope puntope added the type: bug The issue is a confirmed bug. label Jul 21, 2023
@puntope puntope requested a review from a team July 21, 2023 11:32
@puntope puntope self-assigned this Jul 21, 2023
@puntope puntope changed the title Fix/error counting releases Fix error counting RC releases Jul 21, 2023
tomalec added a commit to woocommerce/dewped that referenced this pull request Jul 23, 2023
Add more elaborate description to `--includeRC`.

Related:
 - woocommerce/grow#65
- woocommerce/grow#66
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Considering the PR title will be used as an entry of release note, it would be a bit cleaner if the title also indicates which action to be fixed.

@puntope puntope changed the title Fix error counting RC releases Get Plugin releases Action: Fix error counting RC releases Jul 24, 2023
@puntope puntope merged commit beebb96 into trunk Jul 24, 2023
2 checks passed
@puntope puntope deleted the fix/error-counting-releases branch July 24, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[actions] changelog: fix type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix condition when loading RC versions.
2 participants