Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused step id from the run-qit-extension action #130

Merged
merged 1 commit into from
May 14, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

In PR #127, the QIT test types api and e2e were renamed. After renaming, they are inconsistent with corresponding steps.<step_id>.

Upon further checking, it appears that these steps.<step_id> are not being used. This PR removes them from the run-qit-extension action.

Ref: https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context

Detailed test instructions:

  1. View the commit 82a27ab triggered a workflow run to validate the run-qit-extension action of this PR
  2. View the result of the test workflow run

@eason9487 eason9487 requested a review from a team May 13, 2024 07:58
@eason9487 eason9487 self-assigned this May 13, 2024
Copy link
Contributor

@puntope puntope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @eason9487 LGTM

@eason9487 eason9487 merged commit ec5a9ce into trunk May 14, 2024
1 check passed
@eason9487 eason9487 deleted the tweak/run-qit-extension-ids branch May 14, 2024 01:49
eason9487 added a commit that referenced this pull request May 14, 2024
Remove the unused step `id` from the `run-qit-extension` action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants