Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the v1 of the github-actions package to be deprecated #124

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

Part of #108

This PR:

  • Mark the v1 of the github-actions package deprecated.
  • Change the PR merge base in the release workflow to source/actions-v1 branch

Detailed test instructions:

This PR involves the release processing of the github-actions package. It can only be verified after merging it to source/actions-v1. Therefore, I tested it with a forked repo.

  1. View the merged commit that has the same commit as this PR.
  2. View the workflow that prepares the PR for releasing version 1.11.3.
  3. View the workflow that publish the new release after approving the release PR.
  4. View the workflow that creates the build for v1.11.3 and updates tags.
  5. View the Tags page. The actions-v1, actions-v1.11, and actions-v1.11.3 tags were created and pointed to the same revision.
  6. Read the updated README to see if it is clear enough.

@eason9487 eason9487 requested a review from a team April 26, 2024 11:28
@eason9487 eason9487 self-assigned this Apr 26, 2024
@eason9487 eason9487 mentioned this pull request Apr 26, 2024
26 tasks
@tomalec tomalec self-requested a review April 29, 2024 03:55
@tomalec
Copy link
Member

tomalec commented Apr 29, 2024

Read the updated README to see if it is clear enough.

After the changes from this PR the packages/github-actions/README.md will not cover releasing a new major version.
For the upcoming v2 version, do you plan to remove the changes to README.md from this PR? Leaving 1.x.y patch release instruction only at source/actions-v1? Would you stack them so that for v2, we'll see both ways? Or is the plan to remove major release instructions completely, as they are more complicated?

Or is the idea to keep source/actions-v1 branch away from trunk?

Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code, checked readmes and workflow runs.

LGTM Assuming, I understood correctly the release process split, and we'll keep source/actions-v1 as a separate branch & not plan to merge it into trunk

@eason9487
Copy link
Member Author

Hi @tomalec, thanks for the review!

Or is the idea to keep source/actions-v1 branch away from trunk?

Assuming, I understood correctly the release process split, and we'll keep source/actions-v1 as a separate branch & not plan to merge it into trunk

Yes! I set the source/actions-v1 as a protected branch and it will be kept and not be merged into trunk.

@eason9487 eason9487 merged commit 871e1a6 into source/actions-v1 May 9, 2024
2 checks passed
@eason9487 eason9487 deleted the update/108-nodejs-v20-github-actions-deprecated-v1 branch May 9, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants