Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the run-qit-extension action to use Node.js v20 #120

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Apr 25, 2024

Changes proposed in this Pull Request:

Part of #108

This PR upgrades the run-qit-extension action to use Node.js v20.

📌 Checklist before merging (@eason9487)

  • Revert f0b21e0 before merging this PR

Detailed test instructions:

  1. View a previous workflow run used v1 action
  2. View a test workflow run used updated action

@eason9487 eason9487 requested a review from a team April 25, 2024 08:33
@eason9487 eason9487 self-assigned this Apr 25, 2024
@eason9487 eason9487 mentioned this pull request Apr 25, 2024
26 tasks
Copy link
Contributor

@mikkamp mikkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates they look good to me.

I can confirm the warnings are no longer there in the latest run. There are a lot of temporary changes in this PR, however they look pretty sane to me.

…t PR branch with the test build of `run-qit-annotate`."

This reverts commit f0b21e0.
@eason9487 eason9487 merged commit 19da941 into update/108-nodejs-v20 Apr 26, 2024
@eason9487 eason9487 deleted the update/108-nodejs-v20-github-actions-run-qit-extension branch April 26, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants