Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the fundamental of the github-actions package and its get-release-notes, prepare-node, and update-version-tags actions to use Node.js v20 #112

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Apr 22, 2024

Changes proposed in this Pull Request:

Part of #108

This PR:

  • Bump dependencies and regenerate package-lock.json for the package github-actions with Node.js v20.
  • Set minimum support for Node.js to ">=18", which aligns with the dependencies' minimum ([email protected]).
  • Simplify the rollup config.
  • Add the 'node:' prefix to explicitly indicate it requires a Node.js core module.
  • Upgrade the workflows related to release processing in GitHub Actions to use Node.js v20.
  • Upgrade the related actions of the github-actions package to use Node.js v20.
    • Upgrade the get-release-notes action.
    • Upgrade the prepare-node action.
    • Upgrade the update-version-tags action.

💡 Other actions will be upgraded in subsequent PRs.
💡 The <repo_directory>/.nvmrc and other GitHub Actions workflows will be updated in a separate PR.

Detailed test instructions:

This PR involves the release processing of the github-actions package. It can only be verified after merging it to trunk. Therefore, I tested it with a forked repo.

  1. View the merged PR that has the same commits as this PR.
  2. View the workflow that prepares the PR for releasing version 2.0.0 of the github-actions package.
  3. View the workflow that publish the new release after approving the release PR.
  4. View the workflow that creates the build for v2.0.0 and updates tags.
  5. View the Tags page. The actions-v2, actions-v2.0, and actions-v2.0.0 tags were created and pointed to the same revision. The actions-v1 and actions-v1.* tags were not changed.
  6. The related workflows don't get the warnings about deprecated Node.js
    image

@eason9487 eason9487 requested a review from a team April 22, 2024 10:34
@eason9487 eason9487 self-assigned this Apr 22, 2024
@eason9487 eason9487 changed the title Upgrade the base and get-release-notes, prepare-node, and update-version-tags actions of the package github-actions to use Node.js v20 Upgrade the fundamental of the github-actions package and its get-release-notes, prepare-node, and update-version-tags actions to use Node.js v20 Apr 22, 2024
Copy link

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eason9487, thanks for the updates 🙌

The changes all look good and can't see any issue with the actions in your forked repo. Left one comment for my own clarification but it's not a blocker so LGTM ✅

@eason9487 eason9487 mentioned this pull request Apr 23, 2024
26 tasks
…`prepare-node`, and `update-version-tags` actions.

Address: #112 (comment)
@eason9487 eason9487 merged commit 089e42a into update/108-nodejs-v20 Apr 23, 2024
2 checks passed
@eason9487 eason9487 deleted the update/108-nodejs-v20-github-actions branch April 23, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants