Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade JS package generator-grow to use Node.js v20 #111

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Upgrade JS package generator-grow to use Node.js v20 #111

merged 5 commits into from
Apr 23, 2024

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Apr 19, 2024 •
edited
Loading

Changes proposed in this Pull Request:

Part of #108

This PR:

  • Bump dependencies and regenerate package-lock.json with Node.js v20.
  • Set minimum support for Node.js to "^18.17.0 || >=20.5.0", which align with the dependencies' minimum ([email protected]).
  • Add the 'node:' prefix to explicitly indicate it requires a Node.js core module.
  • Remove an unused file - ./generators/github/package.json
  • Fix the incompatible paths when composing generators.
  • Fix the tests.

Detailed test instructions:

  1. Use Node.js >= 20.5.0
  2. cd packages/js/generator-grow
  3. npm install
  4. npm test to see if tests can pass
  5. npm install -g yo
  6. npm link
  7. Find a temporary empty directory
  8. npm init
  9. yo grow or yo grow:github to see if it can add boilerplate
  10. Repeat the test with Node.js matches ^18.17.0

@eason9487 eason9487 requested a review from a team April 19, 2024 09:51
@eason9487 eason9487 self-assigned this Apr 19, 2024
martynmjones
martynmjones approved these changes Apr 22, 2024
View reviewed changes
Copy link

@martynmjones martynmjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eason9487, thanks for updating Node!

Tested locally with version 20.5.0/ 18.17.0 and all steps were successful so LGTM ✅

@eason9487 eason9487 merged commit 4eace98 into update/108-nodejs-v20 Apr 23, 2024
2 checks passed
@eason9487 eason9487 deleted the update/108-nodejs-v20-generator-grow branch April 23, 2024 02:18
@eason9487 eason9487 mentioned this pull request Apr 23, 2024
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martynmjones martynmjones martynmjones approved these changes

Assignees

@eason9487 eason9487

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eason9487 @martynmjones