Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum budget limit #2583

Open
wants to merge 55 commits into
base: update/2535-consolidate-ad-creation-ccf-merged
Choose a base branch
from
Open

Add minimum budget limit #2583

wants to merge 55 commits into from

Commits on Sep 5, 2024

  1. Updates validateCampaign with daily limit check

    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f6c9f55 View commit details
    Browse the repository at this point in the history

  2. Adds validateCampaign tests

    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    dbfb972 View commit details
    Browse the repository at this point in the history

  3. Adds getHighestBudget utility

    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    fb36ca6 View commit details
    Browse the repository at this point in the history

  4. Adds daily limit data lookup to paid ads setup sections

    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    41956ca View commit details
    Browse the repository at this point in the history

  5. Fixes linter warnings

    @dsawardekar
    dsawardekar committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9ef16c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Style error message accordingly.

    @asvinb
    asvinb committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5741e6b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge branch 'feature/2459-campaign-creation-flow' into update/2459-a… 

    …dd-minimum-budget-limit
    @dsawardekar
    dsawardekar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ac7753c View commit details
    Browse the repository at this point in the history

  2. Adds e2e tests

    @dsawardekar
    dsawardekar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    beb3700 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge branch 'feature/2459-campaign-creation-flow' into update/2459-a… 

    …dd-minimum-budget-limit
    @dsawardekar
    dsawardekar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c7f5a36 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Uses form opts instead of values

    @dsawardekar
    dsawardekar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    1d41c1b View commit details
    Browse the repository at this point in the history

  2. Update countryCodes and validation callback

    @dsawardekar
    dsawardekar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    585bbbd View commit details
    Browse the repository at this point in the history

  3. Updates unit tests

    @dsawardekar
    dsawardekar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    f35ac9d View commit details
    Browse the repository at this point in the history

  4. Fixes linter warnings

    @dsawardekar
    dsawardekar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6804415 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Do not pass uneeded props.

    @asvinb
    asvinb committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d62bc02 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Format currency for recommended budget.

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    603d9c4 View commit details
    Browse the repository at this point in the history

  2. Update E2E test.

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f73150b View commit details
    Browse the repository at this point in the history

  3. Fix E2E test.

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f1fd765 View commit details
    Browse the repository at this point in the history

  4. Fix e2e test.

    @asvinb
    asvinb committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7adc092 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Add useValidateCampaignWithCountryCodes hook.

    @asvinb
    asvinb committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    90e8d95 View commit details
    Browse the repository at this point in the history

  2. Fix unit test.

    @asvinb
    asvinb committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    811461f View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Do not trigger fetch if there are no countryCodes.

    @asvinb
    asvinb committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    eb70d33 View commit details
    Browse the repository at this point in the history

  2. Add loading property to know when the hook is ready.

    @asvinb
    asvinb committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a502b7a View commit details
    Browse the repository at this point in the history

  3. Remove condition to display PaidAdsSetupSections.

    @asvinb
    asvinb committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    34c58a9 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Merge branch 'feature/2459-campaign-creation-flow' into update/2459-a… 

    …dd-minimum-budget-limit
    @asvinb
    asvinb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5d794ed View commit details
    Browse the repository at this point in the history

  2. Add getAdsBudgetRecommendations selector.

    @asvinb
    asvinb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4d80b45 View commit details
    Browse the repository at this point in the history

  3. Update hooks.

    @asvinb
    asvinb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    44d9eed View commit details
    Browse the repository at this point in the history

  4. Add JSDocs.

    @asvinb
    asvinb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    29b6920 View commit details
    Browse the repository at this point in the history

  5. More descriptive JSDocs.

    @asvinb
    asvinb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a1a5cf4 View commit details
    Browse the repository at this point in the history

  6. Fix linting errors.

    @asvinb
    asvinb committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a7a2eba View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Apply change.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    684fd02 View commit details
    Browse the repository at this point in the history

  2. Add JSdocs for returned value.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    447bff0 View commit details
    Browse the repository at this point in the history

  3. Fix JS errors.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c85bdf1 View commit details
    Browse the repository at this point in the history

  4. Fix e2e test.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    74e0dd8 View commit details
    Browse the repository at this point in the history

  5. Address CR feedback.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    6fc4a6b View commit details
    Browse the repository at this point in the history

  6. Add JSDocs.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    716581b View commit details
    Browse the repository at this point in the history

  7. Simplify hooks.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2c4f863 View commit details
    Browse the repository at this point in the history

  8. Fix JS tests.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2d51b4a View commit details
    Browse the repository at this point in the history

  9. Rename function.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ab6a397 View commit details
    Browse the repository at this point in the history

  10. Delete unused file.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    edccd57 View commit details
    Browse the repository at this point in the history

  11. Review comments.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7f7261a View commit details
    Browse the repository at this point in the history

  12. Update minimum amount displayed to the user.

    @asvinb
    asvinb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    330697c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Make sure country codes are loaded.

    @asvinb
    asvinb committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    0d8c6bd View commit details
    Browse the repository at this point in the history

  2. Fix e2e test.

    @asvinb
    asvinb committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5f2f291 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Take precision settings into consideration.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    03b1167 View commit details
    Browse the repository at this point in the history

  2. Fix e2e tests.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7432760 View commit details
    Browse the repository at this point in the history

  3. Convert to float.

    @asvinb
    asvinb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f23a52c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'feature/2459-campaign-creation-flow' into update/2459-a… 

    …dd-minimum-budget-limit
    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    df07674 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'update/2535-consolidate-ad-creation-ccf-merged' into up… 

    …date/2459-add-minimum-budget-limit
    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d1ed9cf View commit details
    Browse the repository at this point in the history

  3. Fix bad merge.

    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    dfb1bc9 View commit details
    Browse the repository at this point in the history

  4. Simplify code where countryCodes is needed.

    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    c89ac46 View commit details
    Browse the repository at this point in the history

  5. Remove unused props.

    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6d7a287 View commit details
    Browse the repository at this point in the history

  6. Fix loaded value

    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3ff8276 View commit details
    Browse the repository at this point in the history

  7. Fix e2e test

    @asvinb
    asvinb committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    78fc8bb View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Use Math.ceil.

    @asvinb
    asvinb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3fb0832 View commit details
    Browse the repository at this point in the history

  2. Fix failing test.

    @asvinb
    asvinb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ce9ad99 View commit details
    Browse the repository at this point in the history