Add conditional repository_owner to workflow #7871
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: thanks @julek-wolfssl for the tip on manually disabling workflows in a fork. That works, but I found it rather unintuitive. I still think it's a good idea to not run all the upstream workflows by default. We could have contributors that may be time-limited on computing power or something. It just seems to be a waste. Thoughts? |
|
Jenkins retest this please |
julek-wolfssl
requested changes
Aug 14, 2024
There was a problem hiding this comment.
I don't think this is a good way to do this. Its still going to run just result in errors. This also adds unnecessary and unintuitive clutter to the actions. If you really want to I'm sure there is a way to disable the actions through the gh api and run that as cron job.
julek-wolfssl
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a workflow condition to only run the workflow on wolfssl-owned repositories (in this case, async.yml). I propose doing this on all workflows, but this PR is only for the first one to open a discussion and code review. I'm happy to make the changes for others.
Why?
I've recently begun implementing automated Espressif CI testing. One of the things that has been annoying and even problematic has been all the upstream workflows running in my fork, such as this sync from upstream:
Worse, some of them appear to never stop:
Although I think that's actually a GitHub bug, as the ones from last month are not actually running:
Fixes zd# n/a
Testing
How did you test?
not tested.
Checklist