Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] display wallet birthday #943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GUI] display wallet birthday #943

wants to merge 1 commit into from

Conversation

pythcoiner
Copy link
Collaborator

@pythcoiner pythcoiner commented Jan 29, 2024 •
edited
Loading

fixes #805

@pythcoiner
Copy link
Collaborator Author

should I display date as MM/DD/YY, as it can be confusing to some european country that use DD/MM/YY?
maybe better to same as the rescan date settings:
image

@pythcoiner pythcoiner changed the title [WIP] display wallet birthday [GUI] display wallet birthday Feb 2, 2024
@pythcoiner pythcoiner marked this pull request as ready for review February 2, 2024 10:06
@pythcoiner
Copy link
Collaborator Author

comments have been adressed

@darosior
Copy link
Member

Just to give an update on this, it's being stuck because we had a disagreement (Kevin and i) about how this should be displayed to the user. I'm not sure where this landed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darosior darosior darosior left review comments

@edouardparis edouardparis Awaiting requested review from edouardparis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GUI] Display wallet creation date at installer and in settings
3 participants
@pythcoiner @darosior @edouardparis