Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check coldcard version and request user to upgrade #1346

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Check coldcard version and request user to upgrade #1346

merged 1 commit into from
Sep 17, 2024

Conversation

edouardparis
Copy link
Member

Close #1343

@edouardparis edouardparis force-pushed the Check-coldcard-version-and-add-request-to-upgrade branch from 080ce88 to 7371c9d Compare September 17, 2024 09:24
@pythcoiner
Copy link
Collaborator

image
the message is the same wether we choose PSWSH or taproo, maybe if taproot is selected we should ask for version 6.3.3?

jp1ac4
jp1ac4 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7371c9d.

jp1ac4
jp1ac4 reviewed Sep 17, 2024
View reviewed changes
gui/ui/src/component/hw.rs Outdated
column(vec![
text::p1_bold("Unsupported firmware version").into(),
text::p1_regular(format!(
"Install version superior or equal to {}",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think it would sound more natural to say "Install version {} or later".

@edouardparis
Copy link
Member Author

edouardparis commented Sep 17, 2024 •
edited
Loading

the message is the same wether we choose PSWSH or taproo, maybe if taproot is selected we should ask for version 6.3.3?

We avoid to add more logic for now, it is past rc and goes straight into release and we have the taproot support warning when user uses the taproot dropdown.

@pythcoiner
Copy link
Collaborator

tACK 7371c9d

@edouardparis edouardparis force-pushed the Check-coldcard-version-and-add-request-to-upgrade branch from 7371c9d to 7124e09 Compare September 17, 2024 09:57
jp1ac4
jp1ac4 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@jp1ac4 jp1ac4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7124e09.

edouardparis
edouardparis commented Sep 17, 2024
View reviewed changes
Copy link
Member Author

@edouardparis edouardparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-ACK 7124e09

@edouardparis edouardparis merged commit 6e55191 into wizardsardine:master Sep 17, 2024
31 checks passed
@edouardparis edouardparis mentioned this pull request Sep 17, 2024
Merged
edouardparis added a commit that referenced this pull request Sep 17, 2024
@edouardparis
Merge #1347: Check coldcard version and request user to upgrade
58624fb 
47b8ad2 Check coldcard version and request user to upgrade (edouardparis)

Pull request description:

  backport of #1346

ACKs for top commit:
  jp1ac4:
    utACK 47b8ad2.
  edouardparis:
    Self-ACK 47b8ad2

Tree-SHA512: a11e24928e5ad5aa268bb216563ec7c35fb95cbed14032b3fd4d099983dcc52473efd216ebe659e8beade18d0c6c7b26db5e1b479f5a6f2676b4d5965600f5bc
@nondiremanuel nondiremanuel added this to the v7 - Liana milestone Sep 17, 2024
@edouardparis edouardparis deleted the Check-coldcard-version-and-add-request-to-upgrade branch September 17, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp1ac4 jp1ac4 jp1ac4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Liana General
Status: Done
Milestone
v7 - Liana
Development

Successfully merging this pull request may close these issues.

Edit Coldcard descriptor registration error message
4 participants
@edouardparis @pythcoiner @jp1ac4 @nondiremanuel