WIP: Upgrade rust-miniscript / rust-bitcoin to latest version #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythcoiner
reviewed
Aug 24, 2024
| _ => None, | ||
| } | ||
| .ok_or(LianaPolicyError::IncompatibleDesc)?; | ||
| SemanticPolicy::Thresh(thresh) if thresh.is_or() && thresh.n() > 1 => { |
There was a problem hiding this comment.
shouldn't we check thresh.k() == 1?
Suggested change
| SemanticPolicy::Thresh(thresh) if thresh.is_or() && thresh.n() > 1 => { | |
| SemanticPolicy::Thresh(thresh) if thresh.is_or() && thresh.n() > 1 && threshk() == 1 => { |
|
Yes. In general i don't think the code here is correct. I need to go through the descriptor core logic one more time. |
|
also not from these PR, but here if assert fail we will panic shouldn'nt we error instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to go over the changes again, and this introduces a massive performance hit. From quick profiling i think it's from upstream changes in the miniscript policy compiler.
Running
cargo test descriptorsbefore:After:
Fixes #1224.