Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak build on FreeBSD #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unbreak build on FreeBSD #22

wants to merge 2 commits into from

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Apr 13, 2024

No description provided.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.76%. Comparing base (4b46eb9) to head (3763e9c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   50.77%   50.76%   -0.01%     
==========================================
  Files         941      941              
  Lines       87404    87404              
  Branches    45306    45311       +5     
==========================================
- Hits        44376    44370       -6     
- Misses      38315    38675     +360     
+ Partials     4713     4359     -354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romangg
Copy link
Member

romangg commented Apr 13, 2024

Thanks!

Commit message of fix(build): adjust Linux-only header after... needs to be changed. The scope can only be one of these, but not build.

Also message line limit is 90.

In file included from theseus-ship-6.0.0/main_wayland.cpp:10:
In file included from /usr/include/como/base/wayland/xwl_platform.h:17:
In file included from /usr/include/como/render/wayland/xwl_platform.h:15:
In file included from /usr/include/como/render/post/night_color_manager.h:14:
/usr/include/como/base/os/clock/skew_notifier.h:8:10:
  fatal error: 'skew_notifier_engine.h' file not found
    8 | #include "skew_notifier_engine.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~
como/xwl/socket.cpp:124:9: error: use of undeclared identifier 'close'
        close(fd);
        ^
como/xwl/socket.cpp:129:9: error: use of undeclared identifier 'close'
        close(fd);
        ^
como/xwl/socket.cpp:155:44: error: use of undeclared identifier 'getuid'
    if (info.st_uid != 0 && info.st_uid != getuid()) {
                                           ^
como/xwl/socket.cpp:184:17: error: use of undeclared identifier 'close'
                close(fd);
                ^
como/xwl/socket.cpp:223:9: error: use of undeclared identifier 'close'
        close(fd);
        ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants