445: Stores spoken keyboard prompts to Recents #530
Conversation
cinadia
requested review from
nicholas-cook,
stechkev,
nerdsosky,
cxw320,
PaulKlauser and
mattttvaughn
as code owners
| ) | ||
| viewModel.addNewPhrase(text, PresetCategories.RECENTS.id) |
There was a problem hiding this comment.
You exposed a flaw in how our categories are set up, nice! We don't actually want to be storing phrases under the "RECENTS" category, instead we determine RECENTS by just looking at the most recently used phrases PhrasesUseCase#getPhrasesForCategory().
Totally understand how you got here, and we should clean up the API to not allow creating a phrase with "Recent" as the category, could you create a ticket on the board to track that? Up to you whether or not you tackle that, but we should get it written down.
As far as the defect at hand, I don't think we actually want just anything spoken from the keyboard to be saved, and this is corroborated by how the iOS app works. Instead, Android is currently missing functionality where a user can save a phrase directly from the keyboard. Download the Vocable iOS app to your Mac and poke around to see what I mean. Once you feel comfortable, I think we should discard the current bug as "won't-fix" and write up an enhancement to match iOS's functionality here.
There was a problem hiding this comment.
I created a new issue for the API cleanup: #534
As for saving phrases directly from the keyboard, on iOS they're stored under the "My Sayings" category, but on Android the "My Sayings" category is depricated. Would you like to bring it back?
There was a problem hiding this comment.
Updated #445 to reflect adding the My Sayings enhancement. Can probably close this PR
Description:
Stores keyboard prompts that the user Speaks to the Recents category
Resolves #445