Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependencyOnlyDeploy for external contracts config #492

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nataouze
Copy link
Contributor

@nataouze nataouze commented Oct 22, 2023

Fixes #341 and #342

Adds an optional execute field in the external.contracts configuration which indicates whether the external.contracts.deploy scripts should be executed (defaults to true for retrocompatibilty). If set to false, the external deploy scripts are not executed by default but can be used as tag-based dependencies when running the main (non-external) deploy scripts.

DeploymentsManager.executeDeployScripts signature is changed to accept the parameters scriptPathBags and funcByFilePath as it does not load the deployment tags and functions before execution anymore: DeploymentsManager.loadDeployScripts must be run first to generate these arguments.

@nataouze
Copy link
Contributor Author

Finally changed the implementation to make it less intrusive: DeploymentsManager.executeDeployScripts is back to what it was and does not require to run DeploymentsManager.loadDeployScripts first. The external non-execute deploy scripts are loaded in DeploymentsManager.db.dependenciesScriptPathBags and DeploymentsManager.db.dependenciesFuncByFilePath fields instead which are used in DeploymentsManager.executeDeployScripts as fallback if tags or scripts are not found from the main scripts folders.

@wighawag it would be great if you could take a look at this

@lucastAB
Copy link

Oh man, this is helpful.

@miroslavchmelka
Copy link

i was looking for this feature, will it be merged?

@mdguo
Copy link

mdguo commented Nov 17, 2023

+1

1 similar comment
@tbinetruy
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy script dependencies from external not resolved when using --tags
5 participants