Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #841: button groups in 'settings-buttons.ts' #862

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lyss0306
Copy link

Solution to issue #841
Removed 'showFreq', 'showRelatedVideosTray', 'showRecentlyPlayed', 'showDetailsTray' from group 6 Added 'showFreq', 'showRelatedVideosTray', 'showRecentlyPlayed', 'showDetailsTray' to group 14 (settings tab 3)

Solution to issue whyboris#841
Removed 'showFreq', 'showRelatedVideosTray', 'showRecentlyPlayed', 'showDetailsTray' from group 6
Added 'showFreq', 'showRelatedVideosTray', 'showRecentlyPlayed', 'showDetailsTray' to group 14 (settings tab 3)
@whyboris
Copy link
Owner

@lyss0306 thank you for the PR 🙇‍♂️ I'm hoping to get to reviewing all PRs and merging them in this winter 😅 (still trying to finish my DIY kitchen work in the house -- so many projects, so little time!)

Thank you for your patience ♥

@whyboris
Copy link
Owner

@lyss0306 - when I click on Files changed I'm surprised to see an addition of a new file without changes to a previous file. Perhaps you've accidentally added the file rather than replacing the already-present settings-buttons.ts ? Could you move this file to the location of the current one: src/app/common/settings-buttons.ts replacing the old one - this way it will be easy to see what lines of code changed 👍😁👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants