Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove info button and viewmode logic #624

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

Denpeer
Copy link
Contributor

@Denpeer Denpeer commented Jul 17, 2024

Description (Proposed Changes)

remove info button which expands nutritional plan dashboard widgets
Before:
Pasted image 20240718005057
After:
Pasted image 20240718012744

Link to the issue :

Tests

No new tests added, existing tests for the removed button not found

@Dieterbe I'm having some issues running the test locally, maybe somebody can help me through this?

Checklist

Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

@Dieterbe
Copy link
Contributor

i think this is perfect! :)

@Dieterbe Dieterbe self-requested a review July 18, 2024 15:40
Copy link
Contributor

@Dieterbe Dieterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@Dieterbe Dieterbe merged commit fee0e63 into wger-project:master Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants