-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove outputs from repository source files, update build scripts #144
Conversation
LGTM |
Do you mean creating releases daily? |
Let's discuss this here. |
Nice, I'm at my phone atm. I'll see later if I can do it else tomorrow if there can be done something with the gitignore file so users get less changes in version control when they run the Makefiles themselves 🙂. I also need to make a little update to the build.sh files due to the deleted Release directory I noticed. The necessary files were updated, I'll add a little description to have a better record of what has changed tomorrow. |
2790029
to
8f251df
Compare
8f251df
to
5131a49
Compare
5131a49
to
7eec4ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next to removing the build outputs the .gitignore
file and build scripts were updated.
Now, when the build scripts are executed the compiled files would be put into the dist/
directory - the directory name is commonly used for compiled output files (/dist
"distributable", the compiled code/library). It would be created instead of the current Release
directory - which was the only directory in the repository root starting with an uppercase letter.
Below I'll add some descriptions to the changes. Please let me know if changes are desired.
What I never asked: Do we even need to keep the build scripts when the releases are made available via GitHub? As they run the |
We must keep the scripts, as |
Thanks for your reply @AlbertShown. I see that it's good to keep them. The updates that are made to them here can then serve a good purpose as well. I would merge this then, if I may. |
LGTM. |
This PR removes the build outputs and release files from the repositories source files. It keeps the
Makefile
s.Like mentioned in some other places e.g. #114 it's not the preferred way of distributing build and release files.
From #143: "Nightly" pre-compiled builds can be found as release artifacts in the Actions section of the webui repository https://github.com/webui-dev/webui/actions. Similar like they are found on this PR branch action:
https://github.com/webui-dev/webui/actions/runs/5626124981?pr=143