peer_connection: Implement state changes after spec and fix race #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 61.29% 61.33% +0.04%
==========================================
Files 532 532
Lines 49731 49812 +81
Branches 12656 12680 +24
==========================================
+ Hits 30484 30554 +70
+ Misses 9867 9858 -9
- Partials 9380 9400 +20 ☔ View full report in Codecov by Sentry. |
haaspors
changed the title
DTLS transport state was previously acquired and sent over to the async context returned. This would in some rare cases obviously lead to updating peer connection state with an old DTLS transport state. This would in turn lead to PeerConnection not updating it's state correctly. Sometimes we would see PeerConnection never reaching Connected.
haaspors
force-pushed
the
peerconnection-state
branch
from
cdd9550
to
fcdef6f
Compare
PeerConnectionInternal was initialized with default transports and then mutated right after. This resulted in create_ice_transport() using the default DTLS transport instance which again led to state transition reading DTLS transport state from the wrong instance.
rainliu
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/TR/webrtc/#rtcpeerconnectionstate-enum
Ported from PION
pion/webrtc#2435