Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error clarification #470

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Error clarification #470

merged 3 commits into from
Jul 25, 2023

Conversation

rogurotus
Copy link
Contributor

I get failed to verify rtsp auth tag (RtcpFailedToVerifyAuthTag) errors intermittently but the description of the error is not sufficient to identify the problem.

it could be:
different encryption methods,
broken package,
wrong auth tag

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 68.75% and project coverage change: -0.12% ⚠️

Comparison is base (de25e64) 61.58% compared to head (ca96006) 61.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   61.58%   61.47%   -0.12%     
==========================================
  Files         537      537              
  Lines       49511    49511              
  Branches    12316    12314       -2     
==========================================
- Hits        30492    30436      -56     
- Misses       9875     9888      +13     
- Partials     9144     9187      +43     
Files Changed Coverage Δ
...nts/src/algorithms/select_settings/tie_breaking.rs 78.26% <ø> (-21.74%) ⬇️
rtp/src/codecs/opus/opus_test.rs 60.00% <ø> (-4.29%) ⬇️
srtp/src/cipher/cipher_aes_cm_hmac_sha1.rs 71.63% <0.00%> (-1.56%) ⬇️
srtp/src/error.rs 0.00% <0.00%> (ø)
turn/src/proto/dontfrag/dontfrag_test.rs 73.33% <ø> (-3.14%) ⬇️
util/src/vnet/conn_map/conn_map_test.rs 45.79% <100.00%> (ø)
util/src/vnet/net/net_test.rs 41.02% <100.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rainliu rainliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. and thanks for fix clippy error.

@rainliu rainliu merged commit c66520f into webrtc-rs:master Jul 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants