Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code cov #248

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix code cov #248

merged 1 commit into from
Jul 6, 2023

Conversation

BennyThink
Copy link
Member

@BennyThink BennyThink commented Jul 5, 2023

worth mentioning:

  1. this commit remove on push d104c1f
  2. this commit make clean will delete more files, including codecov.txt 23bbed8
  3. although on push was added back here 13281d9 , we would first run make test and then make

So codecov.txt is missing! So we're missing code coverage data for more than a year!

@BennyThink BennyThink requested a review from n0vad3v July 5, 2023 20:06
@github-actions
Copy link

github-actions bot commented Jul 5, 2023


ghcr.io/webp-sh/webp_server_go (debian 12.0)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)


@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #248 (9253631) into master (9efead2) will decrease coverage by 54.53%.
The diff coverage is 29.05%.

@@             Coverage Diff             @@
##           master     #248       +/-   ##
===========================================
- Coverage   83.57%   29.05%   -54.53%     
===========================================
  Files           6        2        -4     
  Lines         542      179      -363     
===========================================
- Hits          453       52      -401     
- Misses         61      122       +61     
+ Partials       28        5       -23     
Impacted Files Coverage Δ
helper/helper.go 20.00% <20.00%> (ø)
config/config.go 87.50% <87.50%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@n0vad3v n0vad3v merged commit 3699c49 into master Jul 6, 2023
6 of 8 checks passed
@n0vad3v n0vad3v deleted the fix_codecov branch July 6, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants