Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Remove spinner in top right when loading pages #86

Merged

Conversation

shardel23
Copy link
Contributor


title: BugFix: Remove spinner in top right when loading pages

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • [X ] πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Noticed there's a spinner showing up on the top right corner when pages are loading.
This is part of the NextTopLoader.
Since NextTopLoader includes a loading progress bar, there's no need in an extra spinner, especially when it is misplaced.

QA Instructions, Screenshots, Recordings

Current state:
image

After changes: No spinner, only loading progress bar.

Added/updated tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

@vercel
Copy link

vercel bot commented Jul 10, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @webdevcody on Vercel.

@webdevcody first needs to authorize it.

@webdevcody webdevcody merged commit 92324e7 into webdevcody:main Jul 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants