Fix eslint errors and auth error #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraneCaleta
approved these changes
Aug 5, 2023
|
@devhiko you have some issues |
|
yeah code changed a lot since i pushed this PR. |
|
failing tests |
|
Ahaha, this merge will last to eternity :D cuz i changed eslint rules and all files have errors now ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: Issue # | Fix auth type error
Discord Username: @
What type of PR is this? (select all that apply)
Description
when you try to contribute project and run
npm run pr-precheckcommand, you were seeing a type error related with next-auth at type-check step, now its gone and everything okay.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?