Skip to content

Commit

Permalink
remove todo (#7121)
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex authored Jun 25, 2024
1 parent a000b59 commit 3ec3d49
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/web3-eth-contract/test/integration/contract_methods.test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ describe('contract', () => {
});

it('should returns errors on reverts', async () => {
// TODO hardhat reverts but sends an undefined receipt, needs investigation
// hardhat errors during revert when sending the transaction so no receipt will be returned.
if (getSystemTestBackend() === BACKEND.HARDHAT) {
// eslint-disable-next-line jest/no-conditional-expect
await expect(
Expand Down

1 comment on commit 3ec3d49

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 3ec3d49 Previous: a000b59 Ratio
processingTx 9095 ops/sec (±4.35%) 9311 ops/sec (±3.94%) 1.02
processingContractDeploy 38991 ops/sec (±7.52%) 40798 ops/sec (±6.81%) 1.05
processingContractMethodSend 16115 ops/sec (±6.53%) 16315 ops/sec (±9.15%) 1.01
processingContractMethodCall 27966 ops/sec (±6.39%) 28490 ops/sec (±6.67%) 1.02
abiEncode 43025 ops/sec (±7.48%) 45570 ops/sec (±7.74%) 1.06
abiDecode 29972 ops/sec (±7.90%) 30895 ops/sec (±8.28%) 1.03
sign 1494 ops/sec (±3.30%) 1555 ops/sec (±3.70%) 1.04
verify 371 ops/sec (±0.43%) 374 ops/sec (±0.58%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.