Skip to content

Commit

Permalink
[flex] Don't apply transferred min/max sizes.
Browse files Browse the repository at this point in the history
https://chromium.googlesource.com/chromium/src/+/f357fe9f912bd1723fb73fdb693c6825dae23390

... introduced a change where we applied the transferred min/max sizes
to the inline min/max sizes.

This was unintentional. The spec is unclear on this situation (after
checking with the spec author), so filed an issue here:
w3c/csswg-drafts#10997

We may change back again, but at least this brings us in-line with
other browsers for the moment.

Fixed: 368562235
Change-Id: I6f353e7d2e1ef0e1077af2b3b76c5f42632cc6b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5907910
Reviewed-by: David Grogan <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1363796}
  • Loading branch information
bfgeek authored and chromium-wpt-export-bot committed Oct 3, 2024
1 parent 0fbfc14 commit 2ef4a5b
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions css/css-flexbox/aspect-ratio-transferred-max-size.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!DOCTYPE html>
<link rel="help" href="https://github.com/w3c/csswg-drafts/issues/10997">
<link rel="match" href="../reference/ref-filled-green-100px-square-only.html">
<p>Test passes if there is a filled green square.</p>
<div style="display: flex; width: 100px;">
<div style="aspect-ratio: 1/2; max-height: 100px; flex: 1; background: green;"></div>
</div>

0 comments on commit 2ef4a5b

Please sign in to comment.