v1alpha3 - Rename BareMetal to BYOB #228

bboreham · 2020-06-18T11:58:41Z

For comparison to #224

Many things have changed: - Where we had a List of Machine, we now have a YAML stream, i.e. multiple documents separated by --- - Where we had a single struct, we must deal with a ClusterAPI struct and a provider-specific struct Fix up ParseAndDefaultAndValidate to return both cluster structs

(renamed from "actuator")

(renamed from 'actuator')

(Needs a bit more work on BareMetalMachine to be useful)

So we can treat an error on 'kubectl get nodes' as transient, while still logging that it happened.

To fit with upstream requirements: https://cluster-api.sigs.k8s.io/developer/architecture/controllers/cluster.html#infrastructure-provider

Otherwise it's really hard to figure out what went wrong.

Blank means use the default, but when ImageRepository is set the current code is failing.

Signed-off-by: Dennis Marttinen <[email protected]>

Almost everywhere uses Public.Address or Private.Address, so these other ones are just a source of confusion.

Fail parsing if manifest lacks Cluster or BareMetalCluster definition

palemtnrider

This terminology is good with me. I'm curious if others are OK with it.

luxas · 2020-07-29T12:31:37Z

Replaced by #224

bboreham added 30 commits June 2, 2020 15:12

Update ClusterAPI from v1alpha1 to v1alpha3: basic types

d8485be

Update install_plans for v1alpha3

a354d9a

Update runners/ssh for v1alpha3

30ebb1a

Deal with changes in upstream Sealed Secrets API

d05c151

Deal with upstream change in kube-proxy config

98552a2

Deal with upstream changes in cordon helper

085a26f

Update os handling for extra 'spec' struct

63b2509

Update 'specs' package for v1alpha3

68ccafa

Fetch fallback namespace from manifest, not from cluster

aa679f7

For v1alpha3 reuse cluster parsing from specs package

51bba51

BareMetal machine controller updated to v1alpha3

0604f41

(renamed from "actuator")

BareMetal cluster controller updated to v1alpha3

f09bd2d

(renamed from 'actuator')

Update controller main to v1alpha3

2b91e66

Remove Scheme registration from helper function

8f145d2

Remove unused applyAddons() function

ed212b6

Update kubeconfig for v1alpha3

cfa45fb

Re-use machine.GetKubernetesVersionFromManifest()

82e36bc

Update machine controller after adding 'spec' field

5b29e85

Update apply_test for v1alpha3

5a1765a

Update manifest test to v1alpha3

2e0d569

Update multimaster integration test to v1alpha3

53c932b

Add chanwit/plandiff to go.mod

fd3a2e5

cluster.yaml should be a stream not a list

61a4468

Use 'require' to fail tests before they crash

d13f2e6

Make UpdateWithGeneratedNames() not-fail on v1alpha3

9f9ac44

(Needs a bit more work on BareMetalMachine to be useful)

Ensure wksctl program can parse YAMLs

3238ee9

Fix typo in test data

c2c5f09

Return error if seed node plan fails

f1cdda4

Enable controller-gen for baremetal types

a6e6518

bboreham and others added 23 commits June 2, 2020 15:36

Refactor multimaster test error reporting again

f9972cf

So we can treat an error on 'kubectl get nodes' as transient, while still logging that it happened.

Execute unit tests one at a time to avoid running out of memory

d56bb79

Rename field from ExternalLoadBalancer to ControlPlaneEndpoint

d9949a2

To fit with upstream requirements: https://cluster-api.sigs.k8s.io/developer/architecture/controllers/cluster.html#infrastructure-provider

Update generated files after rebases

8c8d140

Update crds_vfsdata.go

e300929

Add a 'ready' field to BareMetalCluster status

39bf092

Don't need hugo to run integration tests

a9a48a9

Update docunmentation for v1alpha3

4c87926

Update vfsdata

9e23716

Include error message from 'kubectl apply'

06b5ec9

Otherwise it's really hard to figure out what went wrong.

Fix compile error in apply_test

d79e785

Avoid failure when controllerImage is blank

bf134c7

Blank means use the default, but when ImageRepository is set the current code is failing.

Fail parsing if manifest lacks Cluster or BareMetalCluster definition

f9ea884

Signed-off-by: Dennis Marttinen <[email protected]>

Fix up incorrect use of PrivateAddress in test

5a62418

Remove top-level address and port fields

d8ff13f

Almost everywhere uses Public.Address or Private.Address, so these other ones are just a source of confusion.

Update vfsdata for CRD change

2c65b3d

Merge pull request #211 from twelho/update-to-v1alpha3

4715afc

Fail parsing if manifest lacks Cluster or BareMetalCluster definition

Clarify parsing error message

8359aa4

Add 'bootstrap' field to Machine; it's mandatory

6fc3ed9

Rename to BYOB

d6c801d

Remove obsolete override

e353fc3

Update vfsdata files

c8b0f42

Add workaround for install problem

d87377f

palemtnrider approved these changes Jun 18, 2020

View reviewed changes

bboreham force-pushed the update-to-v1alpha3 branch 3 times, most recently from 550d9da to 2b644aa Compare June 24, 2020 14:49

Base automatically changed from update-to-v1alpha3 to master June 24, 2020 16:21

luxas closed this Jul 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1alpha3 - Rename BareMetal to BYOB #228

v1alpha3 - Rename BareMetal to BYOB #228

bboreham commented Jun 18, 2020

palemtnrider left a comment

luxas commented Jul 29, 2020

v1alpha3 - Rename BareMetal to BYOB #228

v1alpha3 - Rename BareMetal to BYOB #228

Conversation

bboreham commented Jun 18, 2020

palemtnrider left a comment

Choose a reason for hiding this comment

luxas commented Jul 29, 2020