Deal with moving MACs #2437

rade · 2016-07-10T21:41:49Z

rade · 2016-07-10T22:19:12Z

Things left to do:

make it work - see networking broken for containers with moved MAC #2436 (comment) onwards
convince ourselves that we aren't introducing any packet loops
refactor to get rid of MacCache.Add and rename MacCache.AddForced to MacCache.Add
refactor to extract the common MacCache interaction and conflict handling in NetworkRouter.handleCapturedPacket and NetworkRouter.handleForwardPacket
add a test, covering both sleeve and fastdp mode

router/network_router.go

+		router.Overlay.(NetworkOverlay).InvalidateRoutes()
+	}
+}
+


awh · 2016-08-10T14:54:11Z

@brb did you mean for this to still be assigned to you?

brb · 2016-08-10T16:30:12Z

Yep, as I haven't convinced myself that we do not introduce loops.

awh · 2016-09-21T10:48:22Z

Needs rebasing on 1.7 after the 1.7.0 release.

otherwise NetworkRouter.handleForwardedPacket fails to clear out the now invalid flows.

We see such packets when a MAC that we previously saw at a remote peer has been moved to ours. Dropping these packets cuts off network connectivity for the new owner of the MAC. Instead we update the MAC cache and flush the flows, to remove the now incorrect entries for that MAC. And carry on as normal.

The absence of the deletion might lead to installation of invalid flows, because the fastdp bridge MAC cache can have stale entries which are used when deciding when/what flows to create.

The former function is obsolete.

The function updates the MAC cache and invalidates routes if needed.

bboreham · 2018-05-23T12:52:31Z

Coming up on two years: what should we do with this?

brb · 2018-06-05T07:24:37Z

I'd prefer to bring this PR to life. First I'd need to refresh context though. Perhaps, it could happen when working on #2877

iExalt · 2020-03-05T19:02:05Z

Any word on this PR/associated issue #2877? I have a use case where moving MACs is intentional and not an error. @brb

bboreham · 2020-03-06T15:32:02Z

Martynas moved to another company so probably isn't going to resurrect this PR.
It is expected to be difficult to understand all the ramifications of the change, and to test them.

#2877 is not really related, except they both touch the same code. This PR targets #2436.

rade force-pushed the 2436-mac-move branch from 7f49be6 to a610fce Compare July 10, 2016 22:07

awh mentioned this pull request Jul 14, 2016

networking broken for containers with moved MAC #2436

Open

rade added this to the 1.6.1 milestone Jul 20, 2016

rade reviewed Jul 21, 2016
View reviewed changes

router/network_router.go

router.Overlay.(NetworkOverlay).InvalidateRoutes()

}

}

This comment was marked as abuse.

Sign in to view

brb force-pushed the 2436-mac-move branch from 2f6b843 to 9de9ae9 Compare July 25, 2016 12:38

brb self-assigned this Jul 28, 2016

brb changed the title ~~[WIP] deal with moving MACs~~ Deal with moving MACs Jul 28, 2016

brb modified the milestones: 1.6.1, 1.6.2 Aug 18, 2016

awh modified the milestones: 1.6.2, 1.7.1 Sep 21, 2016

awh modified the milestones: 1.7.1, 1.7.2, 1.7.3 Oct 5, 2016

brb force-pushed the 2436-mac-move branch from 9de9ae9 to 6e3d824 Compare October 19, 2016 16:35

brb changed the base branch from 1.6 to 1.7 October 19, 2016 16:35

MacCache.AddForced needs to return conflicting peer

17c8dc9

otherwise NetworkRouter.handleForwardedPacket fails to clear out the now invalid flows.

rade and others added 5 commits October 19, 2016 17:35

Delete fastdp bridge MACs when invalidating routes

2408f0e

The absence of the deletion might lead to installation of invalid flows, because the fastdp bridge MAC cache can have stale entries which are used when deciding when/what flows to create.

Replace MacCache.Add by MacCache.AddForced

bfcd8c1

The former function is obsolete.

Extract common parts and move to learnMAC

f029860

The function updates the MAC cache and invalidates routes if needed.

Add container MAC migration tests

6e3d824

awh modified the milestones: 1.7.3, 1.8.1 Nov 4, 2016

bboreham modified the milestones: 1.8.2, 1.8.1 Nov 21, 2016

brb modified the milestones: 1.8.2, 1.8.3 Dec 8, 2016

bboreham modified the milestones: overflow, 1.8.3 Feb 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deal with moving MACs #2437

Deal with moving MACs #2437

rade commented Jul 10, 2016

rade commented Jul 10, 2016 •

edited by brb

Loading

This comment was marked as abuse.

awh commented Aug 10, 2016

brb commented Aug 10, 2016

awh commented Sep 21, 2016

bboreham commented May 23, 2018

brb commented Jun 5, 2018

iExalt commented Mar 5, 2020 •

edited

Loading

bboreham commented Mar 6, 2020

Deal with moving MACs #2437

Are you sure you want to change the base?

Deal with moving MACs #2437

Conversation

rade commented Jul 10, 2016

rade commented Jul 10, 2016 • edited by brb Loading

This comment was marked as abuse.

awh commented Aug 10, 2016

brb commented Aug 10, 2016

awh commented Sep 21, 2016

bboreham commented May 23, 2018

brb commented Jun 5, 2018

iExalt commented Mar 5, 2020 • edited Loading

bboreham commented Mar 6, 2020

rade commented Jul 10, 2016 •

edited by brb

Loading

iExalt commented Mar 5, 2020 •

edited

Loading