cloudwatch: add queryMode attribute #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGibo
requested changes
Jul 16, 2024
| @@ -32,6 +32,7 @@ class CloudwatchMetricsTarget(Target): | |||
| :param hide: controls if given metric is displayed on visualization | |||
| :param datasource: Grafana datasource name | |||
There was a problem hiding this comment.
Please could you add a documentation string for this new parameter?
Suggested change
| :param datasource: Grafana datasource name | |
| :param datasource: Grafana datasource name | |
| :param queryMode: adnafoinsdfinsoginsoigsfoigsfog |
There was a problem hiding this comment.
I added a comment
JamesGibo
approved these changes
Jul 16, 2024
|
When are you going to publish the release or the fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
To generate certain dashboards with the Cloudwatch datasource, specify the queryMode
Why is it a good idea?
Fix a simple issue
Context
For many queries I need this option