Main add graph unit #632
Merged
Main add graph unit #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGibo
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With thanks to my colleagues Damiano Gianotti (https://github.com/D3mianGianoz) and Ianthe Michiels.
What does this do?
Adds the option to specify the unit for a standard
core.Graphpanel. This feature was implemented for thecore.TimeSeriespanel, but not yet forGraph.Why is it a good idea?
It brings a bit of feature parity between the two standard panel types.
Context
For older grafana versions, Graph is the default visualisation, and is still supported (if deprecated). Having feature parity between the two panel types makes it easier to then transition to the TimeSeries panel in the future.
Questions