Heatmap default options (#640)

* Heatmap default options * update changelog --------- Co-authored-by: Sergey Galkin <[email protected]>
weaveworks · Jan 12, 2024 · 715cacd · 715cacd
1 parent 3565974
commit 715cacd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -10,6 +10,7 @@ Changelog
 .. _`docs`: https://grafana.com/docs/grafana/latest/dashboards/build-dashboards/manage-dashboard-links/#dashboard-links
 
 * Added ...
+* Fix default options for Heatmap
 * Add Unit option for Graph panel
 * Added Minimum option for Timeseries
 * Added Maximum option for Timeseries

diff --git a/grafanalib/core.py b/grafanalib/core.py
@@ -3561,7 +3561,7 @@ class Heatmap(Panel):
     heatmap = {}
     hideZeroBuckets = attr.ib(default=False)
     highlightCards = attr.ib(default=True)
-    options = attr.ib(default=None)
+    options = attr.ib(default=attr.Factory(list))
 
     xAxis = attr.ib(
         default=attr.Factory(XAxis),

diff --git a/grafanalib/tests/test_core.py b/grafanalib/tests/test_core.py
@@ -1192,6 +1192,12 @@ def test_sql_target_with_source_files():
     print(t.to_json_data()["targets"][0])
 
 
+def test_default_heatmap():
+    h = G.Heatmap()
+
+    assert h.to_json_data()["options"] == []
+
+
 class TestDashboardLink():
 
     def test_validators(self):