Update condition statement when publishing event during cluster creat…

…ion when creating the secret
weaveworks · Dec 19, 2023 · 48f46c3 · 48f46c3
1 parent 73aa132
commit 48f46c3
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/internal/controller/automatedclusterdiscovery_controller.go b/internal/controller/automatedclusterdiscovery_controller.go
@@ -407,12 +407,13 @@ func (r *AutomatedClusterDiscoveryReconciler) createSecret(ctx context.Context,
 	// publish event for ClusterCreated
 	r.event(acd, corev1.EventTypeNormal, "ClusterCreated", fmt.Sprintf("Cluster %s created", cluster.Name))
 	_, err = controllerutil.CreateOrPatch(ctx, r.Client, secret, func() error {
-		if value, err := clientcmd.Write(*cluster.KubeConfig); err != nil {
+		value, err := clientcmd.Write(*cluster.KubeConfig)
+		if err != nil {
 			return err
-		} else {
-			secret.Data["value"] = value
 		}
 
+		secret.Data["value"] = value
+
 		return nil
 	})
 	if err != nil {